Discriminator field can't be used

[panoukos41]

Hey, I was looking at the split feature instructions and noticed that the discriminator is set to be serialized as _discriminator but CouchDB will not allow that as shown in the picture below because _ character is considered special

[matteobortolazzo]

Ouch, will fix it now!

[matteobortolazzo]

Can you try the latest dev branch? For some reason, I cannot install CouchDB. Since they use the underscore, I thought it was valid

[panoukos41]

I will try It now but should be fine, you can put whatever you want but _, yea that's what I thought too :P

[matteobortolazzo]

Maybe I should call it database_discriminator?

EDIT: Well EF Core calls the column discriminator, so I doubt people will frequently need to use a field called discriminator.

[panoukos41]

I tried it and it works. Hmmm, you could or maybe start it with . or $? I think $ is used for special cases in general since it sets schema on json from what I have seen

[panoukos41]

Also unrelated but do you think GetDatabase<TSource>() could be GetDatabase<TSource>(string discriminator? = null) so that you don't always provide the database name?

[matteobortolazzo]

Do you mind giving it a try? Just change the json attribute in CouchDocument

EDIT: I like the $

[matteobortolazzo]

That's a choice I made because I think that if you have 2 types of documents in 1 DB, the DB name should not be one of the 2 types. Right?

[panoukos41]

Okay, none of . and $ work when I try to search :/

Yea that seems better I was using [JsonObject] attribute better to leave it this way so that it is more explicit

[matteobortolazzo]

Wow, I forgot JsonObject is supported by the library. I thought it was something you were using manually ahah too many features at this point... So you prefer to have GetDatabase<TSource>(string discriminator? = null) right?

[panoukos41]

I don't know now that I gave it more thought it might start to become too much magic :P because if you forget JsonObject you target another DB, at my patched up hack it was convenient since I had my own CouchDocument type and used JsonObject there. Now I feel a bit confused if it would help or not XD

For the discriminator part, I think database_discriminator or db_discriminator should be okay since the user won't really see it or use it himself and it makes sense as a name

[matteobortolazzo]

I opted for split_discriminator.

About the name, I tried GetDatabase<TSource>(string discriminator? = null) but then, if anyone tries to use that overload it will actually call GetDatabase<TSource>(string database, string discriminator? = null).

So please try last time and I release the fix

[panoukos41]

Okay, it works just fine, yea that actually makes sense that it's better this way in the end :D