Support for revisions in Find, AddOrUpdate #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README update to reflect how to use options and how to fork with revisions
Closed
|
Hey, @dmlarionov that's awesome! Sorry for the late review, it's hard to take care of everything! I'll merge into dev, review the other PRs/issues and then release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisions are essential feature for MVCC in CouchDB. Passing a revision to PUT request makes you aware of the conflict (if happen) via response 409 Conflict from CouchDB HTTP API. That's why we need to support passing revisions to
AddOrUpdatemethod.To avoid breaking changes with my addition and while more request options might be introduced in future, I contributed to
DatabaseApiMethodOptionsnamespace and:FindOptions+ICouchDatabase<TSource>.FindAsyncpaired methodAddOrUpdateOptions+ICouchDatabase<TSource>.AddOrUpdateAsyncpaired methodAddOptions+ICouchDatabase<TSource>.AddAsyncpaired methodI suppose in the future another contributors whould't extend method parameters, instead add properties to
DatabaseApiMethodOptions.*Optionsobjects.Unit-tests covering new options are added.
I checked and see that for attachements revisions are already supported by
CouchAttachmentclass which is passingDocumentRevtoDownloadAttachmentAsync(..)andDownloadAttachmentAsStreamAsync(..).Added "Revisions" section to README.