fix: std::filesystem::equivalent does not work for non-exist path #2182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qnixsynapse
approved these changes
Mar 27, 2025
vansangpfiev
added a commit
that referenced
this pull request
Mar 27, 2025
) * fix: std::filesystem::equivalent does not work for non-exist path * chore: enable create file test for all platforms (#2183) --------- Co-authored-by: sangjanai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes an important change to the
SanitizePathfunction inengine/repositories/file_fs_repository.cc. The change simplifies the logic for verifying that a resolved path is within the specified base directory.Path sanitization improvement:
engine/repositories/file_fs_repository.cc: Simplified the loop that checks if the resolved path is within the base directory by replacing it with a string search. This change ensures the resolved path contains the base directory path substring.Fixes Issues
Self Checklist