This repository was archived by the owner on Jun 27, 2022. It is now read-only.
Force PacketHeader's representation to be predictable #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 86.21% (diff: 100%)@@ master #30 diff @@
==========================================
Files 10 10
Lines 2607 2510 -97
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 2223 2164 -59
+ Misses 384 346 -38
Partials 0 0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces the
PacketHeaderrepresentation to be#[repr(C)]. This fixes an issue where the compiler might reorder the struct's fields, which would mess up the unsafe cast to an array of bytes.Currently waiting for the new Rust 15.0 beta to be released and tested against master.
Fixes #29