Feature 4159 handle token cache in cluster #4160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-jcup
force-pushed
the
feature-4159-handle-token-cache-in-cluster
branch
5 times, most recently
from
89501b7 to
064d705
Compare
- introduced pre-cache - refactored self cleaning cache - added new fields - introduced builder - introduced OAuth2OpaqueTokenClusterCachePersistence - added documentation - introduced integration test + unit tests
de-jcup
force-pushed
the
feature-4159-handle-token-cache-in-cluster
branch
from
064d705 to
d2c054c
Compare
de-jcup
force-pushed
the
feature-4159-handle-token-cache-in-cluster
branch
3 times, most recently
from
1611fc3 to
1ca5d21
Compare
- removed unnecessary consructors, where only for test, the test was changed instead. - introduced component to provide cryptoAccessprovider for opaque token introspection response, used this comonent inside selfcleaning cache instance, but also inside cluster token cache (when transforming database entities to cache data objects)
de-jcup
force-pushed
the
feature-4159-handle-token-cache-in-cluster
branch
from
1ca5d21 to
66c50b3
Compare
Due to PR #4187 version 2.11.0 was aready reached. Set to 2.12.0
winzj
approved these changes
May 26, 2025
sechub-commons-core/src/main/java/com/mercedesbenz/sechub/commons/core/cache/CacheData.java
Outdated
Show resolved
Hide resolved
| @@ -163,98 +270,123 @@ public OAuth2AuthenticatedPrincipal introspect(String opaqueToken) throws OAuth2 | |||
| return new OAuth2IntrospectionAuthenticatedPrincipal(username, introspectionClaims, authorities); | |||
| } | |||
|
|
|||
| private OAuth2OpaqueTokenIntrospectionResponse getIntrospectionResponse(String opaqueToken, Instant now) { | |||
| private OAuth2OpaqueTokenIntrospectionResponse getIntrospectionResponseFromInMemoryCache(String opaqueToken, Instant now) { | |||
There was a problem hiding this comment.
This method does more than fetching the introspection response fromt he in-memory cache. If it is not inside the in-memory cache the cluster cache is asked afterwards and updates the in-memory cache. Maybe give this method a more generic name?
...ing/src/main/java/com/mercedesbenz/sechub/spring/security/OAuth2OpaqueTokenIntrospector.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/com/mercedesbenz/sechub/spring/security/OAuth2OpaqueTokenIntrospector.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/mercedesbenz/sechub/spring/security/OAuth2OpaqueTokenIntrospectorTest.java
Show resolved
Hide resolved
sechub-doc/src/docs/asciidoc/documents/shared/concepts/concept_oauth2_handling.adoc
Outdated
Show resolved
Hide resolved
sechub-doc/src/docs/asciidoc/documents/shared/concepts/concept_oauth2_handling.adoc
Outdated
Show resolved
Hide resolved
sechub-doc/src/docs/asciidoc/documents/shared/concepts/concept_oauth2_handling.adoc
Outdated
Show resolved
Hide resolved
.../sechub/sharedkernel/security/clustercache/OAuth2OpaqueTokenClusterCachePersistenceTest.java
Outdated
Show resolved
Hide resolved
.../sechub/sharedkernel/security/clustercache/OAuth2OpaqueTokenClusterCachePersistenceTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR