Auth: Handle invalid account #2865
Merged
+105
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ale5000-git
reviewed
Apr 22, 2025
play-services-core/src/main/kotlin/org/microg/gms/accountaction/ErrorResolver.kt
Outdated
Show resolved
Hide resolved
|
Nice! Great to see this fixed 😭😭😭 |
lucasmz-dev
reviewed
Apr 26, 2025
lucasmz-dev
reviewed
Apr 26, 2025
lucasmz-dev
reviewed
Apr 27, 2025
fynngodau
suggested changes
May 14, 2025
play-services-core/src/main/kotlin/org/microg/gms/accountaction/AccountActionActivity.kt
Outdated
Show resolved
Hide resolved
play-services-core/src/main/kotlin/org/microg/gms/accountaction/ErrorResolver.kt
Outdated
Show resolved
Hide resolved
play-services-core/src/main/kotlin/org/microg/gms/accountaction/Resolution.kt
Outdated
Show resolved
Hide resolved
play-services-core/src/main/kotlin/org/microg/gms/accountaction/AccountActionActivity.kt
Outdated
Show resolved
Hide resolved
|
One thing I noticed is that reauth is not possible if Android ID has changed (i.e. when microG data has been deleted, but accounts were kept). This should be relatively easy to fix, but I don't think it needs to be solved in this PR. 🙂 |
|
When testing this PR, I removed some specific devices from the Security tab in myaccount. A few days later, unrelated to this PR, I was not able to sign in (or reauth) from microG until I changed Android ID; perhaps the device was locked out in a way microG is unable to recover from? The server response was only a generic error. |
Co-authored-by: Lucas <[email protected]>
Co-authored-by: Lucas <[email protected]>
Co-authored-by: Lucas <[email protected]>
mar-v-in
force-pushed
the
fix_account_invalid
branch
from
bbb42a5 to
ce73cce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2731 (comment)
Based on @fynngodau’s solution, use notifications to inform users whether their account has expired. Users can choose to log in again or log out.
Choosing to re-login will be handled based on the newly added reauth interface.