Fido: fix support when targetSdk>=35 #2887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ale5000-git
reviewed
May 2, 2025
...ices-fido/core/src/main/kotlin/org/microg/gms/fido/core/transport/nfc/NfcTransportHandler.kt
Outdated
Show resolved
Hide resolved
|
For your information, it may interest you that I use the fido-core lib for this app: https://codeberg.org/s1m/hw-fido2-provider |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ale5000-git
approved these changes
May 2, 2025
mar-v-in
requested changes
Jun 1, 2025
...ices-fido/core/src/main/kotlin/org/microg/gms/fido/core/transport/usb/UsbTransportHandler.kt
Outdated
Show resolved
Hide resolved
...do/core/src/main/kotlin/org/microg/gms/fido/core/transport/usb/UsbDevicePermissionManager.kt
Outdated
Show resolved
Hide resolved
|
@mar-v-in Do you mind patching the branch yourself ? I'm not available the coming week |
No problem, I'll do it. |
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use fido-core with targetSdk=35, using NFC fails with
Background activity launch blocked!This is because starting with SDK35, either the creator or the sender of the pendingIntent need to allow background activity launch (cf https://developer.android.com/guide/components/activities/background-starts#opt-in-required)