Skip to content

Apply wider exclusion for zipkin-reporter #362

Closed
@jonatan-ivanov

Description

@jonatan-ivanov

It seems Gradle still brings in the zipkin reporter (io.zipkin.reporter2:zipkin-reporter) if one depends on io.micrometer:micrometer-tracing-bridge-brave.

Reproducer:

plugins {
    id 'java'
}

repositories {
    mavenCentral()
}

dependencies {
    implementation 'io.micrometer:micrometer-tracing-bridge-brave:1.+'
}

gradle dependencies produces the following output:

compileClasspath - Compile classpath for source set 'main'.
\--- io.micrometer:micrometer-tracing-bridge-brave:1.+ -> 1.1.5
     +--- io.micrometer:micrometer-tracing:1.1.5
     |    +--- io.micrometer:micrometer-observation:1.11.4
     |    |    \--- io.micrometer:micrometer-commons:1.11.4
     |    +--- io.micrometer:context-propagation:1.0.5
     |    \--- aopalliance:aopalliance:1.0
     +--- org.slf4j:slf4j-api:1.7.36
     +--- io.zipkin.brave:brave:5.14.1
     |    \--- io.zipkin.reporter2:zipkin-reporter-brave:2.16.3
     |         \--- io.zipkin.reporter2:zipkin-reporter:2.16.3
     |              \--- io.zipkin.zipkin2:zipkin:2.23.2
     +--- io.zipkin.brave:brave-context-slf4j:5.14.1
     |    \--- io.zipkin.brave:brave:5.14.1 (*)
     +--- io.zipkin.brave:brave-instrumentation-http:5.14.1
     |    \--- io.zipkin.brave:brave:5.14.1 (*)
     \--- io.zipkin.aws:brave-propagation-aws:0.23.5
          \--- io.zipkin.brave:brave:5.13.7 -> 5.14.1 (*)

Interestingly it works if io.spring.dependency-management plugin is used.

Reported and brainstormed by @alexanderankin and @fbonander on Slack.

Metadata

Metadata

Labels

bugA general bugbuildA change in our build-system

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions