Skip to content

float_control pragma applies to clang #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2024
Merged

float_control pragma applies to clang #183

merged 2 commits into from
Feb 3, 2024

Conversation

walbourn
Copy link
Member

@walbourn walbourn commented Feb 2, 2024

The float_control pragma is supported by clang, so we should enable it there as well as for MSVC. This impacts IsInfinite tests functions and the SSE/SSE2 rounding implementation.

Note that currently the clang/LLVM compiler does not properly respect this pragma for SSE intrinsics code, so the recommendation would be to avoid using /fp:fast with clang/LLVM.

@walbourn
Copy link
Member Author

walbourn commented Feb 2, 2024

@walbourn walbourn merged commit c9a31a6 into main Feb 3, 2024
@walbourn walbourn deleted the clangfix branch February 3, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected results with clang-cl /fp:fast in release mode The clang/LLVM returns bad results for specific code optimizations
3 participants