[python-package] Fix mypy checks in compat.py
#6898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borchero
requested review from
guolinke,
jameslamb,
shiyu1994,
jmoralez and
StrikerRUS
as code owners
jameslamb
requested changes
Apr 29, 2025
There was a problem hiding this comment.
Thanks for working on this!
I'd like to see the specific warnings this is trying to address before approving this PR... maybe I'll be able to suggest something more specific than Any that we could use here. Can you please add them to the PR description in plaintext?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
mypycurrently fails with 36 errors in 6 files. One of these files iscompat.py.Changes
This PR fixes the typing issues in
compat.py, eliminating 2 errors in 1 file. I don't think there is a strong drawback in usingAnyhere, this is a "stub function" anyways.