Skip to content

Update MS.VS. Packages for CG Alert #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WardenGnaw
Copy link
Member

This PR updates the MS.VS packages to update the underlying version of message pack. It also updates the PIA tool to handle AssemblyKeyFileAttribute and AssemblySignatureKeyAttribute

This PR also updates the PIA tool to handle AssemblyKeyFileAttribute
and AssemblySignatureKeyAttribute
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the MS.VS package versions and extends the PIA tooling to recognize two new assembly attributes.

  • Added mappings for AssemblyKeyFileAttribute and AssemblySignatureKeyAttribute in the PIA converter.
  • Bumped several Microsoft.VisualStudio.* package versions in the build settings.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/tools/MakePIAPortableTool/MakePIAPortableTool.cs Add support for two new System.Reflection attributes in PIA tool
build/package_versions.settings.targets Update Microsoft.VisualStudio package versions to new releases
Comments suppressed due to low confidence (2)

src/tools/MakePIAPortableTool/MakePIAPortableTool.cs:43

  • Add a unit or integration test to verify that the PIA tool correctly recognizes and processes AssemblyKeyFileAttribute and AssemblySignatureKeyAttribute.
            { "System.Reflection.AssemblyKeyFileAttribute", System_Runtime },

src/tools/MakePIAPortableTool/MakePIAPortableTool.cs:44

  • Confirm that AssemblySignatureKeyAttribute is a valid attribute in the targeted runtime; if the actual attribute is named differently (e.g., AssemblyKeyNameAttribute), update this mapping accordingly.
            { "System.Reflection.AssemblySignatureKeyAttribute", System_Runtime },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant