Fix emitting ?.
#37019
Merged
Fix emitting ?.
#37019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, guess I'll close #35864 then. |
rbuckton
reviewed
Feb 27, 2020
|
In general this looks good, but there are 5 failing tests. |
Use `emit()` for writing `questionDotToken`, leading to properly calling the emit hooks (which `emitTokenWithComment` doesn't) and printing the comments. This fixes microsoft#35372 by calling its hooks to set the `.__pos` and `.__end` fields. Also, remove `getDotOrQuestionDotToken` which was used only here -- mainly because it seems likely to encourage misusing the `questionDotToken` again. Also, fix a bunch of `visitor` -> `tokenVisiton` calls in `visitorPublic.ts`.
Everything should be fixed now (except for the existing emitting issue). |
rbuckton
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
writeTokenNodefor writingquestionDotToken, leading to properlycalling the emit hooks (which
emitTokenWithCommentdoesn't). Thisfixes #35372 by calling its hooks to set the
.__posand.__endfields.
Also, remove
getDotOrQuestionDotTokenwhich was used only here --mainly because it seems likely to encourage misusing the
questionDotTokenagain.Also, fix a bunch of
visitor->tokenVisitoncalls invisitorPublic.ts.