Fix js declaration emit for inherited and this-typed inherited fields #37970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
approved these changes
Apr 20, 2020
| (): number; | ||
| (x: T_1): U_1; | ||
| <Q_3>(x: Q_3): T_1 & Q_3; | ||
| <Q_4>(x: Q_4): T_1 & Q_4; |
There was a problem hiding this comment.
Not 100% sure what triggered these changes, but seems fine?
There was a problem hiding this comment.
The intervening number got marked as potentially used when traversing the base classes, but then ultimately elided, I believe. I could put in some extra effort to keep the numbers compressed, but because it doesn't particularly matter, I saw no reason to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35932