Skip comparing optional property flag when comparing against discriminant properties #38101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot run dt |
rbuckton
approved these changes
Apr 24, 2020
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
DT looks OK, user tests look OK, and RWC is zero diff, This seems good~ |
|
@DanielRosenwasser does this need to be ported to |
|
le sigh @typescript-bot cherry-pick this to release-3.9 and LKG |
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
|
Hey @DanielRosenwasser, I've opened #38199 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Apr 26, 2020
Component commits: f0aeef1 Skip comparing optional property flag when comparing against discriminant properties
DanielRosenwasser
pushed a commit
that referenced
this pull request
Apr 26, 2020
…e-3.9 (#38199) * Cherry-pick PR #38101 into release-3.9 Component commits: f0aeef1 Skip comparing optional property flag when comparing against discriminant properties * Update LKG Co-authored-by: Wesley Wigham <[email protected]> Co-authored-by: typescript-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
strictNullChecksis on. When that's the case,{x: string | undefined}and{x?: string | undefined}should now both match{x: string} | {x?: undefined}and{x: string} | {x: undefined}. (Since an optionalundefinedis the same as anundefinedfield in everything except what we require be written in declarations).Fixes #35204