Skip to content

Don’t require fourslash completions tests to specify replacementSpan when it’s zero-length #42013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

Don’t require fourslash completions tests to specify replacementSpan when it’s zero-length #42013

merged 1 commit into from
Dec 17, 2020

Conversation

andrewbranch
Copy link
Member

No description provided.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 17, 2020
orta
orta approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If green

@andrewbranch andrewbranch merged commit 3160b5c into microsoft:master Dec 17, 2020
@andrewbranch andrewbranch deleted the fourslash/dont-require-empty-replacement-span branch December 17, 2020 17:45
@gabritto gabritto mentioned this pull request Feb 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orta orta orta approved these changes

Assignees

@andrewbranch andrewbranch

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewbranch @orta @typescript-bot