Skip to content

Fix indentation in DistributionInfo.json #12838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025

Conversation

Antiz96
Copy link
Contributor

@Antiz96 Antiz96 commented Apr 18, 2025

👋

Replace tabs by spaces.
It seems like I accidentally introduced some tabs with the Arch Linux image, sorry 🫣 🤭

Antiz96 added 2 commits April 18, 2025 13:43
Replace (accidental) tabs by spaces
This should a coherent formatting for the future
@Antiz96
Copy link
Contributor Author

Antiz96 commented Apr 18, 2025

I added a quick check to the validate.py script which should prevent this type of mistake and ensure a constant / coherent formatting for the future by verifying that a 4 space indentation is used across the whole DistributionInfo.json file (which is the formatting currently applied).

If it isn't desirable, I can remove it.

@Antiz96
Copy link
Contributor Author

Antiz96 commented Apr 18, 2025

@microsoft-github-policy-service agree

Copy link
Collaborator

@OneBlue OneBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries at all @Antiz96. I was planning to reorganize this file either way.

Thank you for making the fix though !

tofile="b" + sys.argv[1],
)
diff = "".join(diff)
assert diff == "", diff
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for doing this !

@OneBlue OneBlue merged commit 420b7b2 into microsoft:master Apr 21, 2025
3 checks passed
@Antiz96 Antiz96 deleted the fix_indentation branch April 21, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants