Skip to content

Expose json::value::parse for UTF8 string on Windows #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2020
Merged

Expose json::value::parse for UTF8 string on Windows #1350

merged 1 commit into from
Mar 2, 2020

Conversation

garethsb
Copy link
Contributor

@garethsb garethsb commented Mar 2, 2020

Surfactant for @DHowett-MSFT's #1349.

More functionality with less code!

@garethsb garethsb force-pushed the json-parse-utf8-windows branch from 6f810f8 to 5e2db6f Compare March 2, 2020 09:31
@garethsb
Copy link
Contributor Author

garethsb commented Mar 2, 2020

The few test failures are unrelated.

BillyONeal
BillyONeal approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@BillyONeal BillyONeal merged commit cdae258 into microsoft:master Mar 2, 2020
@garethsb garethsb deleted the json-parse-utf8-windows branch March 3, 2020 07:42
@garethsb garethsb mentioned this pull request Apr 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garethsb @BillyONeal