Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1310 added TCP_NODELAY as a performance optimization to ASIO-based
http_client
andhttp_listener
. Unfortunately, the innocent-lookingset_option
can throwboost::system::system_error
, which was not handled and therefore results instd::terminate
.I've never seen this happen on various Windows and Linux environments, but on a macOS VM we have now seen the
http_client
-side issue if the server closes the socket with just the right timing. It's hard to test, often takes 10 minutes in that environment.My approach here is to ignore errors (we've seen EBADF and EINVAL), since this is a performance optimization only, and hard errors will be picked up by the write operation on the socket which follows immediately.