Set better defaults for references and project references to keep MdMerge happy. #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp build |
|
Command 'build' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
/azp run |
|
No pipelines are associated with this pull request. |
Scottj1s
reviewed
May 7, 2020
| @@ -43,6 +43,20 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |||
| <ProxyFileName Condition="'%(Midl.ProxyFileName)'==''">nul</ProxyFileName> | |||
| <TypeLibraryName Condition="'%(Midl.TypeLibraryName)'==''"></TypeLibraryName> | |||
| </Midl> | |||
| <ProjectReference Condition="'$(XamlLanguage)' != 'C++'"> | |||
There was a problem hiding this comment.
these are defaults. if necessary, users could explicitly override in the IDE?
There was a problem hiding this comment.
Correct. Overrides are possible per reference, for all references or conditionally.
Scottj1s
approved these changes
May 7, 2020
|
I like the "to keep MdMerge happy" part. 😉 |
jlaanstra
changed the title
leaf node |
|
What's the status of this PR? |
|
@kennykerr I need to test the razzle build. Will try to do that tomorrow. |
jlaanstra
force-pushed
the
user/jlaans/452
branch
from
64e1e5a to
1207ffc
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current released versions of MdMerge don't like duplicate definitions. This PR attempts to reduce the duplication by not copying reference output to the output folder by default unless this is an application. An application is always a leaf node and its winmd should never be merged into something else anyway.
Overrides are still possible since this is defined in the props file which is imported very early in the build process, to allows folks to change the default if needed. Unit test projects are an example where this might be needed, but there is not a good way to detect them.
A non-C++/WinRT project won't get these defaults and those projects might still require manually setting Private=false, if it is reference by a C++/WinRT project, so this solution isn't perfect but it helps somewhat.
TODO:
Fixes #452