Skip to content

feat(web-components): co-locate types with es modules #34487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

break-stuff
Copy link
Contributor

Previous Behavior

The types and modules were not co-located which makes it harder for tooling to properly associate types with modules

New Behavior

Types and modules are now co-located under the esm directory.

Related Issue(s)

  • Fixes #

@break-stuff break-stuff requested review from a team as code owners May 20, 2025 19:20
Copy link
Contributor

@davatron5000 davatron5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs React Build review.

@tudorpopams tudorpopams requested a review from Hotell May 21, 2025 12:05
@Hotell
Copy link
Contributor

Hotell commented May 21, 2025

The types and modules were not co-located which makes it harder for tooling to properly associate types with modules

not entirely sure I follow here. can you provide more context ?

@Hotell Hotell changed the title co-locate types with es modules feat(web-components): co-locate types with es modules May 21, 2025
@break-stuff break-stuff requested a review from Hotell May 22, 2025 17:24
Copy link

github-actions bot commented May 23, 2025

📊 Bundle size report

✅ No changes found

Copy link

Pull request demo site: URL

@break-stuff break-stuff requested a review from a team as a code owner May 23, 2025 19:58
@break-stuff break-stuff enabled auto-merge (squash) May 23, 2025 20:09
@break-stuff break-stuff merged commit f90b218 into microsoft:master May 27, 2025
12 of 14 checks passed
@break-stuff break-stuff deleted the co-locate-types-with-modules branch May 27, 2025 13:25
@break-stuff break-stuff added this to the flix@ milestone May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants