-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(web-components): co-locate types with es modules #34487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
break-stuff
merged 9 commits into
microsoft:master
from
break-stuff:co-locate-types-with-modules
May 27, 2025
Merged
feat(web-components): co-locate types with es modules #34487
break-stuff
merged 9 commits into
microsoft:master
from
break-stuff:co-locate-types-with-modules
May 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davatron5000
approved these changes
May 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Needs React Build review.
not entirely sure I follow here. can you provide more context ? |
Hotell
reviewed
May 21, 2025
Hotell
approved these changes
May 23, 2025
📊 Bundle size report✅ No changes found |
Pull request demo site: URL |
AtishayMsft
reviewed
May 27, 2025
AtishayMsft
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The types and modules were not co-located which makes it harder for tooling to properly associate types with modules
New Behavior
Types and modules are now co-located under the
esm
directory.Related Issue(s)