Skip to content

WSConfig updates #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 19, 2024
Merged

WSConfig updates #771

merged 7 commits into from
Apr 19, 2024

Conversation

ianhelle
Copy link
Contributor

@ianhelle ianhelle commented Apr 16, 2024 •
edited
Loading

Main fix is to allow additional connection parameters to be used with MSSentinel QueryProvider.

  • Fixing wsconfig
    • updating a lot of legacy code
    • allow link to corresponding settings to persist in WorkstationConfig instance
    • allow it to use Args subkey

MSTICPyConfig

  • Can now use MSSentinel instead of AzureSentinel in msticpyconfig.yaml - the two should be interchangeable but it will migrate to the former by default.

azure_monitor_driver/MS Sentinel:

  • Can specify additional arguments to pass to connect() function by adding an Args subkey
  • This follows the pattern of TI and other providers and supports storage of values in key vault or environment variables
  • You can also pass other authentication parameters (such as client_id, client_secret) in the connect method and these will be passed to the underlying az_connect function.

Fix for vtlookup3.py

  • Fixed problematic way of using nestasyncio - this was causing failures when run from a langchain agent.
    Fix for lookup/tilookup
  • If the progress parameter was not passed it would still try to cancel a non-existent progress task and cause an exception.

ianhelle added 3 commits April 5, 2024 12:28
@ianhelle
Update ws_config to handle kqlmagic connection strings
1dc0521 
Fixed regex parser and added unit test for parenthesized format of string (e.g. tenant("guid").workspace("guid").
Also getting rid of debug print statement from sentinel_utils.py
And updating python_publish github action to use Python 3.11
@ianhelle
- Updated wsconfig.py to do the following:
d773658 
  - track settings from pkg_config/msticpyconfig.yaml
  - use internal value names that match msticpyconfig rather than legacy config.json
  - added support for Args subkey in config
  - renamed the constants so that they are a bit shorter and easier to understand
- Fixing other modules and test cases that use hard-coded values for configuration values to use new constant names
- Fix to vtlookupv3.py
  - fixed detection of use of nestasyncio so that it works more in more cases (previous failed when invoked from langchain agent)
  - fixed cancelling progress bar task ony if it was created
- Minor typing addition to up_utils.py
@ianhelle
Merge remote-tracking branch 'origin/main' into ianhelle/ws-config-co…
b24d6d4 
…nnection-str-2024-04-05
@ianhelle ianhelle requested a review from petebryan April 16, 2024 03:26
petebryan
petebryan approved these changes Apr 17, 2024
View reviewed changes
@ianhelle ianhelle merged commit 36bd044 into main Apr 19, 2024
@ianhelle ianhelle deleted the ianhelle/ws-config-connection-str-2024-04-05 branch April 19, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petebryan petebryan petebryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianhelle @petebryan