Skip to content

Fix edge case in unitary-hack lint #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

orpuente-MS
Copy link
Contributor

Closes #1661. The lint wasn't recursing if a Call was not an operation, therefore, ignoring the arguments of the Call.

Copy link
Member

@minestarks minestarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@orpuente-MS orpuente-MS enabled auto-merge June 26, 2024 18:03
Copy link

Benchmark for db9555b

Click to view benchmark
Test Base PR %
Array append evaluation 346.4±1.74µs 334.6±8.00µs -3.41%
Array literal evaluation 170.4±1.56µs 186.4±1.61µs +9.39%
Array update evaluation 424.8±2.09µs 414.1±9.23µs -2.52%
Core + Standard library compilation 22.2±0.84ms 21.4±0.47ms -3.60%
Deutsch-Jozsa evaluation 5.2±0.08ms 5.1±0.06ms -1.92%
Large file parity evaluation 34.5±0.10ms 34.4±0.08ms -0.29%
Large input file compilation 13.3±0.43ms 13.1±0.22ms -1.50%
Large input file compilation (interpreter) 53.2±3.13ms 52.0±1.31ms -2.26%
Large nested iteration 33.7±0.21ms 32.3±0.24ms -4.15%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1591.7±129.09µs 1554.1±50.98µs -2.36%
Perform Runtime Capabilities Analysis (RCA) on large file sample 8.0±0.15ms 7.9±0.13ms -1.25%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1454.7±125.50µs 1432.1±85.43µs -1.55%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 28.7±0.26ms 28.3±0.39ms -1.39%
Teleport evaluation 93.4±8.94µs 92.9±6.35µs -0.54%

@orpuente-MS orpuente-MS added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 22c8e00 Jun 26, 2024
16 checks passed
@orpuente-MS orpuente-MS deleted the oscarpuente/fix-unitary-hack-lint branch June 26, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong linter warning for operation that calls operation
3 participants