Fix RCA panic #2017
Merged
Fix RCA panic #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orpuente-MS
requested review from
cesarzc,
idavis,
swernli and
minestarks
as code owners
swernli
approved these changes
Nov 12, 2024
minestarks
approved these changes
Nov 13, 2024
cesarzc
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1925
Notes for reviewers
The issue was that a helper function analyzing binary operations was assuming that operands were element values (non-arrays). I just updated it to also consider arrays.
The logic I added to handle binary ops in arrays is marking the output of a binary operation as
Dynamicif either:Dynamic.Dynamic.Dynamicin this context means that it cannot be known at compile time.