[DRAFT] Language service spike #364
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minestarks
force-pushed
the
minestarks/language-service
branch
from
52db268 to
b895c99
Compare
…tarks/language-service-webworker
…tarks/language-service
…b.com/microsoft/qsharp into minestarks/language-service
…tarks/language-service
minestarks
force-pushed
the
minestarks/language-service
branch
from
c1ba75f to
e70f3c4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
| .catch((err: any) => | ||
| logAndPost({ | ||
| // TODO: test this |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality
|
Superseded by #429 . |
minestarks
added a commit
that referenced
this pull request
Jun 27, 2023
- Add a `QSharpLanguageService` class in the npm package that wraps the WASM language service. - Refactor all the web worker proxy logic from `ICompiler` to make it a generic utility that can turn any object into a web worker proxy. This is implemented in [`worker-proxy.ts`](https://github.com/microsoft/qsharp/pull/426/files#diff-d6a9e927974cf2eec1b1ea6996ddc0c25a0209b8c2d741a14fdc2764641d295e). - Expose `getLanguageService()` and `getLanguageServiceWorker()` which use the above. You can reference #364 to see how this will eventually come together in VS Code and the playground. Tracking issue: #396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #396
This branch contains working editor features for VS Code and the playground.
I'm using this PR as a staging area for the various language service features. I'll pull the code out into small PRs for review and merging.