Skip to content

Revert shadow inconsistency opacity fix #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2022

Conversation

lyzhan7
Copy link

@lyzhan7 lyzhan7 commented Aug 25, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This reverts commit a598ee4
There was a bug in this commit that hid further issues with how this fix was implemented. Reverting it temporarily while we revisit the issues in the original bug fix.

Changelog

[macOS] [Fixed] - Revert shadow inconsistency opacity fix

Test Plan

Reverted the merge commit. Checked that RNTester boots without issues on iOS and macOS.

This reverts commit a598ee4, reversing
changes made to 0ef7992.
@lyzhan7 lyzhan7 requested a review from a team as a code owner August 25, 2022 20:50
@lyzhan7 lyzhan7 merged commit 7e8402d into microsoft:main Aug 25, 2022
@lyzhan7 lyzhan7 deleted the lyzhan-revert-fix2 branch August 25, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants