Skip to content

[0.71] Use viewDidChangeBackingProperties to remove the use of notifications in RCTImageView #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2023
Merged

[0.71] Use viewDidChangeBackingProperties to remove the use of notifications in RCTImageView #1840

merged 1 commit into from
Jul 6, 2023

Conversation

lenaic
Copy link

@lenaic lenaic commented Jun 1, 2023 •
edited by Saadnajmi
Loading

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Cherry pick of #1834 to 0.71-stable

Changelog

[macOS] [CHANGED] - Use viewDidChangeBackingProperties for image reloads on backing properties change

Test Plan

Tested by running RNTester on macOS with paper:
Screenshot 2023-06-01 at 17 49 01

@lenaic lenaic requested a review from a team as a code owner June 1, 2023 15:55
Saadnajmi
Saadnajmi approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@Saadnajmi Saadnajmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future, you can just keep the same title with a prefix of "[0.71]". Perhaps I should document that :D

@Saadnajmi Saadnajmi changed the title Cherry-pick image reload on backing properties change fix to 0.71 [0.71] Use viewDidChangeBackingProperties to remove the use of notifications in RCTImageView Jul 6, 2023
@Saadnajmi Saadnajmi merged commit 697b9f4 into microsoft:0.71-stable Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenaic @Saadnajmi