Skip to content

[0.71][DynamicColorMacOS] Downgrade to warning if appearance is nil #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

Saadnajmi
Copy link
Collaborator

Cherry-pick of #1885 to 0.71-stable

@Saadnajmi Saadnajmi requested a review from a team as a code owner July 21, 2023 00:55
@Saadnajmi Saadnajmi changed the title Warning 71 [0.71][DynamicColorMacOS] Downgrade to warning if appearance is nil Jul 21, 2023
@github-actions
Copy link

github-actions bot commented Jul 21, 2023

Fails
🚫

❔ This pull request needs a description.

🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
⚠️

scripts/publish-npm.js#L56 - scripts/publish-npm.js line 56 – 'otp' is assigned a value but never used. (no-unused-vars)

⚠️

scripts/publish-npm.js#L123 - scripts/publish-npm.js line 123 – 'major' is assigned a value but never used. (no-unused-vars)

⚠️

scripts/publish-npm.js#L123 - scripts/publish-npm.js line 123 – 'minor' is assigned a value but never used. (no-unused-vars)

⚠️

scripts/publish-npm.js#L123 - scripts/publish-npm.js line 123 – 'prerelease' is assigned a value but never used. (no-unused-vars)

⚠️

scripts/publish-npm.js#L171 - scripts/publish-npm.js line 171 – 'isLatest' is assigned a value but never used. (no-unused-vars)

Generated by 🚫 dangerJS against 2df382b

@Saadnajmi Saadnajmi changed the base branch from main to 0.71-stable July 21, 2023 01:07
@Saadnajmi Saadnajmi enabled auto-merge (squash) July 21, 2023 02:18
@Saadnajmi Saadnajmi merged commit 1b5f02d into microsoft:0.71-stable Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants