Skip to content

[0.71] Upgrade SocketRocket to 0.7.0 #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

amgleitman
Copy link
Member

0.71-stable counterpart of #1887.

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This upgrades the SocketRocket to 0.7.0, which fixes a number of retain cycle issues.

Changelog

[GENERAL] [FIXED] - Fix retain cycle issues in SocketRocket

Test Plan

Validated that the WebSocket test page still works.
If the CIs also pass, we should be good.

@amgleitman amgleitman requested a review from a team as a code owner July 21, 2023 19:36
@Saadnajmi Saadnajmi changed the title Upgrade SocketRocket to 0.7.0 [0.71] Upgrade SocketRocket to 0.7.0 Jul 21, 2023
@amgleitman amgleitman mentioned this pull request Jul 21, 2023
4 tasks
@amgleitman amgleitman merged commit 5872908 into microsoft:0.71-stable Jul 21, 2023
@amgleitman amgleitman deleted the 0.71-socketrocket-0.7.0 branch July 21, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants