ci(0.76): check publish_react_native_macos with a runtime condition #2311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
changed the title
isStableBranch regex in prepublish-check to search end of string
tido64
previously requested changes
Dec 5, 2024
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
Saadnajmi
force-pushed
the
0.76/publish-3
branch
3 times, most recently
from
d352f63 to
05b4773
Compare
Saadnajmi
changed the title
isStableBranch regex in prepublish-check to search end of string
Saadnajmi
force-pushed
the
0.76/publish-3
branch
from
05b4773 to
e268b6a
Compare
dannyvv
approved these changes
Dec 5, 2024
Saadnajmi
force-pushed
the
0.76/publish-3
branch
from
2994a66 to
0d215b3
Compare
dannyvv
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The syntax
${{ variables.foo }}in Azure Pipelines yml is only valid for template variables. For ournpm-publish.ymlsteps, we are setting a runtime variable, so it cannot be accessed in a${{ }}in a successive steps' condition. We can fix this by slightly refactoring the condition so that it now evaluates at runtime. The solution was taken from here: https://learn.microsoft.com/en-us/azure/devops/pipelines/process/conditions?view=azure-devops&tabs=yaml#variables-created-in-a-step-used-in-subsequent-step-conditionsWhile we're at it, let's add the
--verboseflag too.Test Plan:
CI should pass