ci(0.76): more publish pipeline fixes #2318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
changed the title
workspace:* dependencies in react-native-macos
Saadnajmi
force-pushed
the
0.76/publish-4
branch
2 times, most recently
from
91bc04a to
8e7ef18
Compare
tido64
approved these changes
Dec 9, 2024
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Saadnajmi
force-pushed
the
0.76/publish-4
branch
from
8e7ef18 to
f587e6c
Compare
|
Hi Folks, I responded on the issue, hopefully that helps clarify the distinction here: nrwl/nx#29242 (comment) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A couple of fixes:
nx releasewon't publishreact-native-macosbecause we use Yarn with what they call a local dependency protocol (AKA:workspace:*in our package.json for react-native-macos).nxthinks that Yarn doesn't support this, but it has since Yarn 2+. This is a bug in nx, and I've filed nx-release doesn't release packages using a local dependency protocol when using modern yarn nrwl/nx#29242 . Meanwhile, let's just remove the use that protocol to unblock publish.nx releasecreates a graph of dependent tasks for it's commandnx-release-publish. This seems to be include publishing a bunch of other packages (You can see the graph withnx graph, I've also pasted it here). There's an--excludeTaskDependenciesoption fornx release publish(the subcommand) but notnx release. So.. I'm splitting the command into 2: Runnx releaseand skip publish, then runnx release publishseparately.