ci: set the npm dist-tag in nx release publish
#2484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 22, 2025
vmoroz
approved these changes
Apr 22, 2025
tido64
approved these changes
Apr 23, 2025
Saadnajmi
added a commit
that referenced
this pull request
Apr 23, 2025
Backport of #2484 to `0.78-stable`
Saadnajmi
added a commit
that referenced
this pull request
Apr 23, 2025
Backport of #2484 to `0.77-stable`
Saadnajmi
added a commit
that referenced
this pull request
Apr 23, 2025
Backport of #2484 to `0.76-stable`
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We separate our CI to run
nx releaseas two steps:nx release --skip-publishandnx release publish. The latter seems to not pick up the NPM dist-tag we want to set packages to release with, so it defaults tolatest. This seems solvable by simply passing in--tag., since that gets picked up in this line of code.Test Plan:
Locally ran
nx release-publishwith extra console.logs to make sure the tag was passed in.