[rush] Add install-run-rush-pnpm.js script #3872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stekycz
requested review from
iclanton,
octogonz,
apostolisms and
D4N14L
as code owners
|
@octogonz this looks good to me, could you take a look and consider updating the website to mention this (and |
|
Seems like we should only include this script in the |
|
@iclanton Good point! I have updated the code, please, take a look |
Thanks for pointing this out! Here's some docs: microsoft/rushstack-websites#119 |
octogonz
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3851
Details
The solution completely solves the issue.
How it was tested
I did not test this code but I have tested the script updated manually in my other private repo.
Impacted documentation
It would be nice to mention it in Enabling CI builds. However,
install-run-rushx.jsis not there as well. The same probably applies to Config files.