Code Cleanup #1095
Merged
Code Cleanup #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
reviewed
Jun 10, 2023
| { | ||
| Path default_base = *ad; | ||
| Path default_base = std::move(*ad); |
There was a problem hiding this comment.
Ditto just remove the variable
|
Thanks a bunch! |
BillyONeal
approved these changes
Jun 12, 2023
vicroms
approved these changes
Jun 12, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some cleanups concerning unneeded verbosity and unintentional copies.
I also encountered copies of the containing type inside
OptionalandExpectedif the containing type is const or when returning from const member functions of a const& object. I have to do some additional work to fix this but I want to make you aware of the issue.