Skip to content

[matplotplusplus] update to v1.2.0 #31229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

[matplotplusplus] update to v1.2.0 #31229

wants to merge 14 commits into from

Conversation

aminya
Copy link
Contributor

@aminya aminya commented May 3, 2023 •
edited
Loading

Fixes #26347
Fixes #31724

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@aminya
Copy link
Contributor Author

aminya commented May 3, 2023

Not sure why std::filesystem fails to build on MacOS.

@aminya aminya mentioned this pull request May 3, 2023
Merged
@Adela0814 Adela0814 added the category:port-update The issue is with a library, which is requesting update new revision label May 4, 2023
@Adela0814
Copy link
Contributor

@aminya Please add port-version in vcpkg.json.

@Adela0814
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@Adela0814 Adela0814 marked this pull request as draft May 6, 2023 10:29
@aminya
Copy link
Contributor Author

aminya commented May 11, 2023

@aminya Please add port-version in vcpkg.json.

port-version is 0 here. So it is not needed! Actually, if I add it, vcpkg format-manifest will remove it.

@aminya aminya mentioned this pull request May 11, 2023
Closed
8 tasks
@dg0yt
Copy link
Contributor

dg0yt commented May 12, 2023

May fix #26347.

@jiayuehua jiayuehua mentioned this pull request Jun 3, 2023
Closed
@aminya aminya changed the title [matplotplusplus] update to 2023-02-17 [matplotplusplus] update to v1.2.0 Jun 6, 2023
@aminya aminya marked this pull request as ready for review June 6, 2023 21:44
@aminya
Copy link
Contributor Author

aminya commented Jun 6, 2023

This is ready to go @dg0yt @Adela0814

Adela0814
Adela0814 suggested changes Jun 7, 2023
View reviewed changes
@Adela0814 Adela0814 marked this pull request as draft June 7, 2023 02:57
@aminya aminya marked this pull request as ready for review June 7, 2023 04:30
@dg0yt dg0yt mentioned this pull request Jun 7, 2023
Merged
7 tasks
@jiayuehua
Copy link
Contributor

jiayuehua commented Jun 7, 2023 •
edited
Loading

As #31796 (comment) point out, This pr should also test feature on different platform.

@aminya aminya requested review from Adela0814 and dg0yt June 10, 2023 06:02
@aminya aminya mentioned this pull request Jun 10, 2023
Merged
@aminya
Copy link
Contributor Author

aminya commented Jun 12, 2023 •
edited
Loading

@Adela0814 @dg0yt I merged all the patches upstream. Please approve this. It seems vcpkg is falling behind the upstream.

@Adela0814
Copy link
Contributor

@Adela0814 @dg0yt I merged all the patches upstream. Please approve this. It seems vcpkg is falling behind the upstream.

I have rerun the failed CI triplet, and we need to wait for the CI to finish running.

Adela0814
Adela0814 suggested changes Jun 12, 2023
View reviewed changes
@Adela0814 Adela0814 marked this pull request as draft June 13, 2023 06:58
@aminya aminya marked this pull request as ready for review June 13, 2023 16:58
@Adela0814 Adela0814 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jun 14, 2023
@Adela0814
Copy link
Contributor

@aminya I encountered an error while testing the usage:
Usage:

    find_package(Matplot++ CONFIG REQUIRED)
    # note: 1 additional targets are not displayed.
    target_link_libraries(CMakeTest PRIVATE Matplot++::cimg std::filesystem Matplot++::matplot Matplot++::nodesoup)

Error:

CMake Error at E:/5/vcpkg/installed/x64-windows/share/matplot++/Matplot++Targets.cmake:68 (set_target_properties):
  The link interface of target "Matplot++::cimg" contains:

    ZLIB::ZLIB

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

@Adela0814 Adela0814 marked this pull request as draft June 14, 2023 02:23
@aminya
Copy link
Contributor Author

aminya commented Jun 14, 2023 •
edited
Loading

This target is optional. @Adela0814 You should enable its feature

@Adela0814
Copy link
Contributor

This target is optional. @Adela0814 You should enable its feature

I tested it with all features enabled.
.\vcpkg.exe install matplotplusplus[*]:x64-windows.

@aminya aminya mentioned this pull request Jun 14, 2023
Open
@aminya aminya marked this pull request as ready for review June 14, 2023 09:30
@aminya aminya requested a review from Adela0814 June 14, 2023 09:33
@Adela0814
Copy link
Contributor

All feature test pass on the following triplets:

  • x64-windows
  • x64-windows-static
  • x86-windows

Usage test pass on x64-windows.

@Adela0814
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Adela0814 Adela0814 removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jun 14, 2023
@Adela0814
Copy link
Contributor

@aminya Please fix the conflicts, thanks.

@Adela0814 Adela0814 marked this pull request as draft June 15, 2023 01:34
@Adela0814
Copy link
Contributor

matplotplusplus has been upgraded to 1.2.0 by PR #31796.

@Adela0814 Adela0814 closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adela0814 Adela0814 Adela0814 approved these changes

@dg0yt dg0yt Awaiting requested review from dg0yt

Assignees

@Adela0814 Adela0814

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[matplotplusplus] update to v1.2.0 matplotplusplus update to 1.1.0
4 participants
@aminya @Adela0814 @dg0yt @jiayuehua