fix: dynamic debug configs sometimes having the wrong type #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added logic to rename the dynamic type to the "preferred" type (such as from pwa-node to node), but didn't take into account that sometimes the config providers return a different type to their main type. For npm scripts, for example, they return a `node-terminal` type instead of `pwa-node`. Changing the type to `node` resulted in broken configs.
tanhakabir
approved these changes
Sep 2, 2022
roblourens
approved these changes
Oct 3, 2022
connor4312
added a commit
that referenced
this pull request
Oct 3, 2022
fix: dynamic debug configs sometimes having the wrong type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added logic to rename the dynamic type to the "preferred" type (such as from pwa-node to node), but didn't take into account that sometimes the config providers return a different type to their main type. For npm scripts, for example, they return a
node-terminaltype instead ofpwa-node. Changing the type tonoderesulted in broken configs.