feat: support ETX in stdio console endings #1615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug console output sometimes gets clumped together when capturing stdout/err instead of console calls since data is sent to DAP as soon as it arrives. This change changes the behavior do that output is sent to DAP on newlines. It also looks out for ETX characters and, if it finds those, it switches to sending output to DAP on each ETX. This allows for better handling of multiline log entries. Fixes microsoft/vscode#175763
|
The failing test is fixed in main already |
TylerLeonhardt
previously approved these changes
Mar 25, 2023
|
@connor4312 merged in main but the build is still red? |
ulugbekna
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #1590, but uses our existing dependency on
split2instead. They don't really supportSymbol.splitvery well, so slight hackery is needed.