fix: Blazor sources sometimes being missing #1716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref dotnet/runtime#86754 A true fix is being applied in .net, but this will take time to trickle down.
|
Build appears to be a flake |
rzhao271
reviewed
Jun 7, 2023
| @@ -1412,18 +1412,19 @@ export class Thread implements IVariableStoreLocationProvider { | |||
| // Hack: Node 16 seems to not report its 0th context where it loads some | |||
| // initial scripts. Pretend these are actually loaded in the 2nd (main) context. | |||
| // https://github.com/nodejs/node/issues/47438 | |||
| if ( | |||
There was a problem hiding this comment.
Is this block and/or the comment right above it still needed?
There was a problem hiding this comment.
No -- instead of reassigning the execution context ID's from Node to id 1 which they do emit, we instead automatically create the missing execution context when a scriptParsed event comes in.
alexr00
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref dotnet/runtime#86754
A true fix is being applied in .net, but this will take time to trickle down.