fix: eval webpack config breakpoints not setting #1833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V8 does not resolve URL-set breakpoints when the script in question only has that URL via a sourceURL mapping. I also noticed an issue with per-script entrypoint breakpoints where another file with the same name, or part of the same name, could incorrectly remove the entrypoint breakpoint early. It's fine to just leave the breakpoint around -- can be slightly slower, but better than missing the breakpoint entirely. Fixes microsoft/vscode#194988
lramos15
previously approved these changes
Oct 6, 2023
rzhao271
approved these changes
Oct 6, 2023
This was referenced Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 does not resolve URL-set breakpoints when the script in question only
has that URL via a sourceURL mapping.
I also noticed an issue with per-script entrypoint breakpoints where
another file with the same name, or part of the same name, could
incorrectly remove the entrypoint breakpoint early. It's fine to just
leave the breakpoint around -- can be slightly slower, but better than
missing the breakpoint entirely.
Fixes microsoft/vscode#194988