Skip to content

fix: also use script ID bps if there is a different embeddername #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: also use script ID bps if there is a different embeddername #1846

merged 1 commit into from
Oct 12, 2023

Conversation

connor4312
Copy link
Member

@connor4312 connor4312 enabled auto-merge (squash) October 12, 2023 16:51
@andreamah
Copy link

failed build?

@connor4312
Copy link
Member Author

There's a few flakes in there

@connor4312 connor4312 merged commit 045f7b6 into main Oct 12, 2023
@connor4312 connor4312 deleted the connor4312/more-embeddded-script-fixes branch October 12, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@connor4312 connor4312

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connor4312 @andreamah @rzhao271