Skip to content

Support virtual filesystems Fixes #154 #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

marcellourbani
Copy link
Contributor

@marcellourbani marcellourbani commented Nov 13, 2023

I basically added 2 features, logically distinct who boil down to the same concept of custom URL schema support in location URLs:

  • support for virtual filesystems (i.e. "adt:a4s/foo","js-viz-download:/foo/bar" )
  • support for command URLs (i.e. "command:myextension.mycommand?par1=foo&par2=bar")

The 1st is for any virtual filesystem, like i.e. ssh fs or Abap FS, current implementation tested with explicit schemas in location URLs, implicit ones might work as is or require replacing path and fs functions in getCandidateDiskPaths with vscode awere alternatives

The 2nd is for my specific use case: resolving URLs is expensive, so by encoding vscode commands as URLs I can do that only when the user clicks on them. It's a standard vscode feature, not tied to my extension

@connor4312 connor4312 enabled auto-merge (squash) November 16, 2023 18:39
@connor4312 connor4312 merged commit 431533b into microsoft:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants