chore: update dependencies #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New syntax in the vitest types failed the build. We were pretty outdated, so bring all deps up-to-date
connor4312
commented
May 19, 2022
| "watch": "concurrently \"npm:watch:*\"", | ||
| "watch:ext": "tsc --watch", | ||
| "watch:esm": "tsc --watch -p tsconfig.browser.json", | ||
| "watch:css": "npm run compile:css && chokidar \"src/**/*.css\" -c \"cpy --parents --cwd=src '**/*.css' ../out/esm\"" | ||
| }, | ||
| "dependencies": { | ||
| "@vscode/codicons": "^0.0.28", | ||
| "node-fetch": "^2.6.1" |
There was a problem hiding this comment.
We build the extension for the web, too, and using node-fetch caused errors when the fallback was removed in their recent versions. Use an isomorphic package instead to get nice builds for both the web and node.
sandy081
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New syntax in the vitest types failed the build. We were pretty outdated, so bring all deps up-to-date