Fix typos and improve consistency in Wip code editor design doc page #320
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
reviewed
Jun 4, 2025
| @@ -17,12 +17,12 @@ | |||
| # Overview | |||
|
|
|||
| ## Code structure | |||
| Like other parts of VS Code, the code is organized by the target runtime environment in Monaco. We distinguish between the following target environments | |||
| Like other parts of VS Code, the code is organized by the target runtime environment in Monaco. We distinguish between the following target environments: | |||
There was a problem hiding this comment.
Suggested change
| Like other parts of VS Code, the code is organized by the target runtime environment in Monaco. We distinguish between the following target environments: | |
| Like other parts of VS Code, the code is organized by the target runtime environment in Monaco. We distinguish between the following target environments |
rzhao271
reviewed
Jun 4, 2025
| @@ -85,7 +85,7 @@ However real world applications are usually more complex than that. The Model is | |||
|
|
|||
| In Monaco, the View has no direct way of talking to the Model. Instead it asks ViewModel for data or events, and informs the ViewModel about user actions. So the ViewModel contains the reference to the Model, the state of the View, event handlers and distributors, and transformers that can convert Model data to View info and vice versa. | |||
|
|
|||
| We can take a look at the interface of ViewModel in Monaco to grasp a better idea | |||
| We can take a look at the interface of ViewModel in Monaco to grasp a better idea: | |||
There was a problem hiding this comment.
Removing colons to align with the team's formatting standards
Suggested change
| We can take a look at the interface of ViewModel in Monaco to grasp a better idea: | |
| We can take a look at the interface of ViewModel in Monaco to grasp a better idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.