Insiders on macOS ARM64: Extension Host crashes (`SIGILL`, `EFAULT`, `EPIPE`)

[andreialecu]

Issue Type: Bug

I haven't seen this reported anywhere, so here goes.

Using the latest insiders version on macOS, I noticed that there are stability issues with extensions.

After some time running vscode, the extension host either crashes and needs to be restarted, or the code actions that trigger on saving a document start hanging.

I noticed that in the Developer Tools it frequently logs messages like:

Uncaught Exception:  Error: read EFAULT
    at Pipe.onStreamRead (internal/stream_base_commons.js:205:27)
t.log @ console.ts:137

The EFAULT exceptions might be triggering this behavior.

This also hangs and spins forever:

If I cancel it, then run Developer: Restart Extension Host it will then save properly.

(It's possible one of my extensions might be interfering as well, as I have a ton of them enabled - but I don't remember seeing this on Stable VSCode with Rosetta.)

VS Code version: Code - Insiders 1.53.0-insider (4a875e2, 2020-12-21T12:34:09.548Z)
OS version: Darwin arm64 20.2.0

System Info

Item	Value
CPUs	undefined
GPU Status	2d_canvas: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 3, 3
Memory (System)	8.00GB (0.17GB free)
Process Argv	--crash-reporter-id ea63df4b-e690-4545-96f3-6944dca865ad
Screen Reader	no
VM	0%

Extensions (58)

Extension	Author (truncated)	Version
better-comments	aar	2.1.0
vscode-base64	ada	0.1.0
vsc-rename-files	alf	2.1.0
ng-template	Ang	0.1100.2
vscode-color	ans	0.4.5
vscode-apollo	apo	1.18.0
vscode-zipfs	arc	2.2.2
folder-source-actions	bie	0.2.0
markdown-preview-github-styles	bie	0.1.6
path-intellisense	chr	2.3.0
react-toolkit	Cod	1.1.23
angular-schematics	cyr	4.7.0
vscode-eslint	dba	2.1.14
emulate	Die	1.4.0
es7-react-js-snippets	dsz	3.1.0
gitlens	eam	11.1.0
tsl-problem-matcher	eam	0.3.1
prettier-vscode	esb	5.8.0
vscode-todo-plus	fab	4.18.0
flow-for-vscode	flo	1.5.0
vscode-yarn	gam	1.7.1
beautify	Hoo	1.5.0
vscode-edit-csv	jan	0.5.3
Angular2	joh	11.0.0
vscode-peacock	joh	3.9.1
chat	kar	0.35.0
graphql-for-vscode	kum	1.15.3
vscode-wsl-workspacefolder	lfu	1.1.2
ftp-sync	luk	0.3.9
auto-barrel	mik	1.7.1
dotenv	mik	1.0.1
mongodb-vscode	mon	0.3.0
vscode-csscomb	mrm	5.3.2
vscode-docker	ms-	1.9.0
vscode-edge-devtools	ms-	1.1.1
remote-wsl	ms-	0.52.0
vscode-js-profile-flame	ms-	0.0.13
vsliveshare	ms-	1.0.3375
vsliveshare-audio	ms-	0.1.91
vsliveshare-pack	ms-	0.4.0
debugger-for-chrome	msj	4.12.11
vscode-react-native	msj	1.2.0
angular2-inline	nat	0.0.17
vscode-ios-common-files	Ort	1.0.5
vscode-react-native-storybooks	Ort	2.7.1
format-code-action	roh	0.0.1
vscode-coverage-gutters	rya	2.6.0
vscode-hexdump	sle	1.8.1
move-ts	str	1.12.0
theshukran-react-utils	the	1.0.2
gitflow	vec	1.2.1
es-quotes	vil	0.2.6
vscodeintellicode	Vis	1.2.10
vscode-wakatime	Wak	4.0.10
vscode-html-pug-convertor	way	0.1.1
vscode-ruby	win	0.27.0
code-template-tool	yua	0.6.2
sort-js-object-keys	zen	1.0.6

(2 theme extensions excluded)

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
openlogontheside:30221882
python763:30178808
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
python504:30227505
vswsl492:30208929
wsl2promptcf:30219163
vstry914:30230485
pythonvsdeb440:30224570
unusedpromptcf:30219165
folderexplorercf:30219167
openfilemenucf:30219169
pythonvsded773:30223139
core-portspanel:30233467

[andreialecu]

Possibly relevant, this is also in the developer tools log:

 WARN [File Watcher (chokidar)] Watcher is not using native fsevents library and is falling back to unefficient polling.

[andreialecu]

Also these from when Extension Host actually crashes:

[andreialecu]

One other error I've been seeing in developer tools prior to an Extension Host crash:

ERR Request textDocument/codeAction failed with message: Cannot read .eslintignore file: /Users/andreialecu/Work/proj/.eslintignore
Error: EFAULT: bad address in system call argument, read: Error: Request textDocument/codeAction failed with message: Cannot read .eslintignore file: /Users/andreialecu/Work/proj/.eslintignore
Error: EFAULT: bad address in system call argument, read
	at /Users/andreialecu/.vscode-insiders/extensions/dbaeumer.vscode-eslint-2.1.14/client/out/extension.js:1:52031
	at /Users/andreialecu/.vscode-insiders/extensions/dbaeumer.vscode-eslint-2.1.14/client/out/extension.js:1:52325
	at Immediate.<anonymous> (/Users/andreialecu/.vscode-insiders/extensions/dbaeumer.vscode-eslint-2.1.14/client/out/extension.js:1:52690)
	at processImmediate (internal/timers.js:456:21)

[andreialecu]

New one:

[Extension Host] Error: Illegal argument    at Object.t.illegalArgument (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:50:803)    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1705:214    at d.invokeFunction (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1759:614)    at u._tryExecuteCommand (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4214:45)    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4213:814 (at _executeContributedCommand (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:707:780))
t.log @ /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:336

[andreialecu]

Possibly relevant, this is also in the developer tools log:

 WARN [File Watcher (chokidar)] Watcher is not using native fsevents library and is falling back to unefficient polling.

Likely relevant for this issue: fsevents/fsevents#349

[andreialecu]

@deepak1556 if you need any further information kindly let me know.

I'm curious about one thing

This seems to specify that it's running on node 12, but node 12 isn't compatible with arm64 (at least not the general purpose one). Only node 15 is.

Is this right?

Also, fsevents/fsevents#350 has been merged and pending release as fsevents 2.3.0 which will hopefully happen today, and might help with the chokidar issue.

[deepak1556]

Can you run the arm64 insiders in a new user data dir --user-data-dir <some-absolute-path> and see if the crash continues.

This seems to specify that it's running on node 12, but node 12 isn't compatible with arm64 (at least not the general purpose one). Only node 15 is.

The runtime is patched to work in electron.

[andreialecu]

@deepak1556 I ran:

code-insiders --user-data-dir `mktemp -d` .

Then had to use Reload Window from the command pallette due to some issues with extensions.

Still got the crash:

(hopefully Reload Window didn't mess with the data dir)

Note that it happens randomly, I've seen it mostly happen when the angular app I'm running in the integrated terminal detects a code change and starts compiling. However, it can happen without any integrated terminal tasks running as well.

What I've been doing and helps a bit, was to run Workspaces: Duplicate in new window and run my Run task there (which spawns about 3 nodejs processes).

It's possible it is related to file change detection though. In this particular crash above, it crashed immediately after saving a file, and when angular started recompiling (running via ng serve).

[andreialecu]

Also, at times, this pops up when saving a file and either: a) takes a long time, b) doesn't finish at all (waiting for minutes). I have to cancel it and Reload Window.

While this one was spinning, there was nothing relevant logged in the Developer tools, no warnings or errors.

[andreialecu]

Attaching the CPU profile of the vscode.git warning, which has been popping up repeatedly. git integration definitely seems slow, but not sure if it's git itself being slow or something else.

exthost-840d83.cpuprofile.zip