Skip to content

Code review/comment API explorationย #45945

Closed
@rebornix

Description

@rebornix

To support displaying code comments in the editor, we can leverage viewzone and overlay widget, but as our view components (like view lines, decorations) are absolutely positioned, we want to know the height of viewzone, to archive that

  • we can guess by the content. it has limitation as markdown content can contain images
  • render the overlay widget first, get its height, resize the viewzone and relayout the editor

The second one is how VSTS manages code comments in monaco editor right now, the experience looks smooth.

Metadata

Metadata

Assignees

Labels

*duplicateIssue identified as a duplicate of another issue(s)

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions