Skip to content

Support search in iframe based webview #96307

Closed
@mjbvz

Description

@mjbvz

For #83188

Problem

On desktop, VS Code's webviews using the electron <webview> tag. This gives a nice api for searching inside a webview

However on web we use normal iframes for webviews. These currently don't support the search functionality because there is no equivalent API for searching inside a iframe.

This is one blocker for using normal iframes for the webviews in desktop VS Code: #83188

Request

Implement search for iframe based webviews. This should attempt to match the behavior of the existing search functionality as much as possible

/cc @deepak1556

Metadata

Metadata

Labels

electron-12-updateIssues and items related to electron 12 updatefeature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code Insiderson-release-notesIssue/pull request mentioned in release noteson-testplansandboxRunning VSCode in a node-free environmentwebIssues related to running VSCode in the webwebviewWebview issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions