Skip to content

Fix hover padding regression #213700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix hover padding regression #213700

merged 1 commit into from
May 28, 2024

Conversation

daviddossett
Copy link
Contributor

@daviddossett daviddossett commented May 28, 2024

Fixes #213460

cc @aiday-mar I think these rules were added by you—maybe they need to be added elsewhere if you added them for a specific purpose.

@daviddossett daviddossett self-assigned this May 28, 2024
@daviddossett daviddossett marked this pull request as ready for review May 28, 2024 16:57
@vscodenpa vscodenpa added this to the May 2024 milestone May 28, 2024
@daviddossett daviddossett merged commit 0051e79 into main May 28, 2024
7 checks passed
@daviddossett daviddossett deleted the ddossett/silky-marmot branch May 28, 2024 20:04
@aiday-mar
Copy link
Contributor

aiday-mar commented May 29, 2024

Hi @daviddossett thanks for looking into this. There seems to be a regression in today's Insiders:

Screen.Recording.2024-05-29.at.09.55.47.mov

When you focus on the inner hover parts, you can not see the border on the very right because it is hidden by the outer HTML. I do not recall exactly why the bottom padding was added.

I will add the following CSS without the padding-bottom into the editor layer directly.

.monaco-hover-content {
	padding-right: 2px;
	box-sizing: border-box;
}

@aiday-mar
Copy link
Contributor

The borders appear incorrect generally in today's insiders even with the change above. I will be investigating the issue. @daviddossett I was wondering if you made any other change that could have impacted the hover borders/padding?

@microsoft microsoft locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too much bottom padding in resizeable hovers
4 participants