Task terminal icon has color glitch #249580
Conversation
anthonykim1
added
the
bug
|
After this PR I get: whereas before, the tool icon is always white: |
| export const FAILED_TASK_STATUS: ITerminalStatus = { id: TASK_TERMINAL_STATUS_ID, icon: { ...Codicon.error, color: { id: problemsErrorIconForeground } }, severity: Severity.Error, tooltip: nls.localize('taskTerminalStatus.errors', "Task has errors") }; | ||
| const FAILED_INACTIVE_TASK_STATUS: ITerminalStatus = { id: TASK_TERMINAL_STATUS_ID, icon: { ...Codicon.error, color: { id: problemsErrorIconForeground } }, severity: Severity.Error, tooltip: nls.localize('taskTerminalStatus.errorsInactive', "Task has errors and is waiting...") }; | ||
| const WARNING_TASK_STATUS: ITerminalStatus = { id: TASK_TERMINAL_STATUS_ID, icon: { ...Codicon.warning, color: { id: problemsWarningIconForeground } }, severity: Severity.Warning, tooltip: nls.localize('taskTerminalStatus.warnings', "Task has warnings") }; | ||
| const WARNING_INACTIVE_TASK_STATUS: ITerminalStatus = { id: TASK_TERMINAL_STATUS_ID, icon: { ...Codicon.warning, color: { id: problemsWarningIconForeground } }, severity: Severity.Warning, tooltip: nls.localize('taskTerminalStatus.warningsInactive', "Task has warnings and is waiting...") }; |
There was a problem hiding this comment.
dont think these had effect, but the terminalData.terminal.changeColor?.(problemsErrorIconForeground, true); was what allowed me to really change the color of the icon.
Trying to figure out how I can change the red -> white on user focusing the failed terminal tab.
It seems like it does for the other x icon and the terminal title itself.
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that task terminal status icons use the appropriate problem-theme colors for error and warning states.
- Imports
problemsErrorIconForegroundandproblemsWarningIconForegroundand applies them to the status icon definitions. - Adds runtime calls to
terminal.changeColorin active and inactive branches to override icon colors.
| @@ -125,8 +132,16 @@ export class TaskTerminalStatus extends Disposable { | |||
| } else if (terminalData.problemMatcher.maxMarkerSeverity === MarkerSeverity.Error) { | |||
| this._accessibilitySignalService.playSignal(AccessibilitySignal.taskFailed); | |||
| terminalData.terminal.statusList.add(FAILED_INACTIVE_TASK_STATUS); | |||
| terminalData.terminal.changeColor?.(problemsErrorIconForeground, true); // works but stays red even when focused/hover | |||
There was a problem hiding this comment.
Calling changeColor here without a corresponding revert or reset means the icon may never return to its default color. Introduce logic on blur/unhover or theme change to restore the original color.
| terminalData.terminal.changeColor?.(problemsErrorIconForeground, true); // works but stays red even when focused/hover | |
| terminalData.terminal.changeColor?.(problemsErrorIconForeground, true); // works but stays red even when focused/hover | |
| terminalData.terminal.onBlur(() => terminalData.terminal.resetColor?.()); | |
| terminalData.terminal.onUnhover(() => terminalData.terminal.resetColor?.()); |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
completely irrelevant. terminalData.terminal.onUnhover(() => terminalData.terminal.resetColor?.()); doesnt exist in real life
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where task terminal status icons remained white by assigning theme colors to error and warning icons and programmatically updating the icon color on focus/inactive states.
- Import and apply
problemsErrorIconForegroundandproblemsWarningIconForegroundto error/warning status icons - Updated
FAILED_*andWARNING_*statuses to include acolorproperty - Added
terminal.changeColorcalls in theTaskTerminalStatusclass to enforce the themed colors
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/tasks/browser/taskTerminalStatus.ts:111
- Consider adding automated tests to verify that
changeColorcorrectly applies and resets icon colors on focus and hover, preventing regressions of the color glitch.
terminalData.terminal.changeColor?.(problemsErrorIconForeground, true);
|
@anthonykim1 we want the icon to stay red for as long as the task has errors -- is that what happens via this PR? |
Resolves: #234602
For me, the icon is always white color (regardless of hover&focused), even when task terminal is in failed/error state.
I made some changes in the
taskTerminalStatus.tsfile, but then this makes the icon ALWAYS red for failed/error state task terminal.I'm thinking there may be some focused/hover related thing I might be missing @meganrogge