Skip to content

Move common script into base classes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yodurr opened this issue Apr 14, 2018 · 7 comments
Closed

Move common script into base classes #2

yodurr opened this issue Apr 14, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@yodurr
Copy link
Contributor

yodurr commented Apr 14, 2018

Would be cool to have a dev.ps1 that provides common dev script commands, then the scenario specific scripts can just have the particular tool differences.

One of the challenges is including other ps1 scripts is hard when your starting point is clicking a web link that kicks off boxstarter. The ability to make install 1-click and not require cloning this repo seems more important than the ability to create base class scripts.

@yodurr yodurr added the enhancement New feature or request label Apr 16, 2018
@yodurr yodurr mentioned this issue Jun 7, 2018
@crutkas
Copy link
Member

crutkas commented Jun 8, 2018

Tried doing an PS invoke to another PS file on my github that was refactored out but got the error below:
invoke-expression -Command https://raw.githubusercontent.com/crutkas/windows-dev-box-setup-scripts/master/helper_WindowsExplorerSettings.ps1

ERROR: The term 'https://raw.githubusercontent.com/crutkas/windows-dev-box-setup-scripts/master/helper_WindowsExplorerSettings.ps1' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
The install of tmp2d69.tmp was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\tmp2D69.tmp\tools\ChocolateyInstall.ps1'.
See log for details.

@crutkas
Copy link
Member

crutkas commented Jun 11, 2018

I have a branch that does this now

What I think as part of this would be see if we can’t pass in Args too so we can have one master and then the subpages just call the master with overrides via args.

@crutkas
Copy link
Member

crutkas commented Jun 11, 2018

@yodurr
Copy link
Contributor Author

yodurr commented Jun 18, 2018

Woot! This will be a big help. Can't wait to make this the new normal.

@crutkas
Copy link
Member

crutkas commented Jun 18, 2018

think this can be tested now. once the devapp.ps1 you're happy with, we can either

  • work on the calling URL so we don't have to alter / include URL and branch
  • work on proper enums vs calling scripts directly
  • port others over (then do top 2)

@yodurr
Copy link
Contributor Author

yodurr commented Jul 26, 2018

PR #59 created

@yodurr
Copy link
Contributor Author

yodurr commented Aug 2, 2018

done.

@yodurr yodurr closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants