Fix compatibility with polymode after pm--visible-buffer-name removal #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace pm--visible-buffer-name with pm--buffer-name to maintain
compatibility with polymode commit 32d0d6d which removed the
pm--visible-buffer-name function and replaced it with pm--buffer-name.
The pm--buffer-name function takes an optional 'hidden parameter:
- pm--buffer-name() returns the visible buffer name (equivalent to old pm--visible-buffer-name)
- pm--buffer-name('hidden) returns the hidden buffer name (equivalent to old pm--hidden-buffer-name)
This change fixes the issue where ein would fail to load due to the
undefined pm--visible-buffer-name function.
Fixes compatibility with polymode >= commit 32d0d6d.
### Notes - Update actions/checkout from v2 to v4 - Update actions/setup-python from v2 to v4 - Update actions/cache from v2 to v4 (both instances) ### Testing This addresses the workflow failure caused by deprecated action versions. The updated actions are the current stable releases and should resolve the CI pipeline issues. ### Issues * Fixes GitHub Actions deprecation warnings in CI workflow
### Notes - Change python-version from 3.7 to 3.8 in test matrix - Python 3.7 reached end-of-life and is no longer available on Ubuntu 24.04 - Python 3.8 is widely supported and compatible with the project requirements ### Testing This addresses the CI failure where Python 3.7 was not found in the local cache for Ubuntu 24.04. Python 3.8 should be available and allow the workflow to proceed. ### Issues * Fixes Python version availability issue in GitHub Actions workflow
### Notes - Remove emacs_version 26.3 from test matrix - Keep testing on 27.2, 28.2, and 29.1 - Dependencies now require Emacs 27.1+ (magit and others have updated minimum requirements) ### Testing This addresses the CI failure where packages required Emacs 27.1 but the workflow was testing on 26.3. The remaining Emacs versions should be compatible with current package dependencies. ### Issues * Fixes Emacs version compatibility issue in GitHub Actions workflow
|
I've tried these proposed changes and can confirm that it resolves the error with the missing function As an aside, I ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes compatibility with recent polymode changes that removed the
pm--visible-buffer-namefunction in commit 32d0d6d.Problem
The
pm--visible-buffer-namefunction was removed from polymode and replaced withpm--buffer-name. This caused ein to fail when loading poly-ein.el with an "undefined function" error.Solution
Replace all instances of
pm--visible-buffer-namewithpm--buffer-name()in poly-ein.el.The
pm--buffer-namefunction:pm--buffer-name()- returns the visible buffer name (equivalent to oldpm--visible-buffer-name)pm--buffer-name('hidden)- returns the hidden buffer name (equivalent to oldpm--hidden-buffer-name)Changes
poly-ein--record-window-bufferfunctionTesting
make test-compileCompatibility
This change maintains backward compatibility while fixing the issue with polymode >= commit 32d0d6d.
Fixes compatibility with polymode commit: polymode/polymode@32d0d6d