Skip to content

Add data-ph- elements to CTA buttons #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Add data-ph- elements to CTA buttons #1821

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dae51bc
Add data-ph- elements to CTA buttons; update tests appropriately
jkachel Nov 12, 2024
bb7bd02
undoing copy change
jkachel Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ol-components/src/components/LearningResourceExpanded/LearningResourceExpandedV1.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ describe("Learning Resource Expanded", () => {
}) as HTMLAnchorElement

expect(link.href).toMatch(new RegExp(`^${resource.url}/?$`))
expect(link.getAttribute("data-ph-action")).toBe("click-cta")
}
},
)
Expand Down
4 changes: 4 additions & 0 deletions ...ends/ol-components/src/components/LearningResourceExpanded/LearningResourceExpandedV1.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,10 @@ const CallToActionSection = ({
<StyledLink
target="_blank"
size="medium"
data-ph-action="click-cta"
data-ph-offered-by={offeredBy?.code}
data-ph-resource-type={resource.resource_type}
data-ph-resource-id={resource.id}
endIcon={<RiExternalLinkLine />}
href={getCallToActionUrl(resource) || ""}
>
Expand Down
3 changes: 2 additions & 1 deletion ...ol-components/src/components/LearningResourceExpanded/LearningResourceExpandedV2.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,14 @@ describe("Learning Resource Expanded", () => {

setup(resource)

const linkName = "Learn More"
const linkName = "Learn More About"
if (linkName) {
const link = screen.getByRole("link", {
name: linkName,
}) as HTMLAnchorElement

expect(link.href).toMatch(new RegExp(`^${resource.url}/?$`))
expect(link.getAttribute("data-ph-action")).toBe("click-cta")
}
},
)
Expand Down
6 changes: 5 additions & 1 deletion ...ends/ol-components/src/components/LearningResourceExpanded/LearningResourceExpandedV2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ const getCallToActionText = (resource: LearningResource): string => {
const accessCourseMaterials = "Access Course Materials"
const watchOnYouTube = "Watch on YouTube"
const listenToPodcast = "Listen to Podcast"
const learnMore = "Learn More"
const learnMore = "Learn More About"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming V2 isnt displayed anywhere yet. was this copy change intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was not, fixed in bb7bd02

const callsToAction = {
[ResourceTypeEnum.Course]: learnMore,
[ResourceTypeEnum.Program]: learnMore,
Expand Down Expand Up @@ -355,6 +355,10 @@ const CallToActionSection = ({
<StyledLink
target="_blank"
size="medium"
data-ph-action="click-cta"
data-ph-offered-by={offeredBy?.code}
data-ph-resource-type={resource.resource_type}
data-ph-resource-id={resource.id}
endIcon={<RiExternalLinkLine />}
href={getCallToActionUrl(resource) || ""}
>
Expand Down
Loading